[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add ACPI support for camera in waddledoo

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39360 )

Change subject: mb/google/dedede: Add ACPI support for camera in waddledoo
......................................................................

Patch Set 21:

(4 comments)

https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@7 
PS16, Line 7: WDoo
> Please mention the full name Waddledoo somewhere.

Updated

https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@9 
PS16, Line 9: schmatics
> schematics

Updated

https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@13 
PS16, Line 13:
> I’d prefer if the baseboard and variant change were in separate commits. Something like: […]

Updated

https://review.coreboot.org/c/coreboot/+/39360/20/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/waddledoo/include/variant/acpi/camera.asl:

PS20:
> Please add that to the variant commit.

Updated