Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39848 )
Change subject: mb/google/deltaur: Update onboard memory config
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39848/9/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/deltan/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/9/src/mainboard/google/deltau...
PS9, Line 56: .spd_smbus_address[1] = 0xa2},
Yes, I checked Sarien. The same two CH for DQS map. Because we use CH0 and CH1. […]
It should be following for delatn with DIMM1 and DIMM2 at ch0 and ch1 respectively right?
spd_smbus_address[0] = 0xa0;
spd_smbus_address[1] = NULL;
spd_smbus_address[2] = 0xa2;
spd_smbus_address[3] = NULL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29059f09dd08c81b5ca5fe1215f33871835703fe
Gerrit-Change-Number: 39848
Gerrit-PatchSet: 9
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 27 Mar 2020 20:11:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment