Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31332 )
Change subject: superio/nsc: Introduce common early_serial ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31332/1/src/superio/nsc/common/Kconfig File src/superio/nsc/common/Kconfig:
https://review.coreboot.org/#/c/31332/1/src/superio/nsc/common/Kconfig@1 PS1, Line 1: ## : ## This file is part of the coreboot project. : ## : ## Copyright (C) 2011 Advanced Micro Devices, Inc. : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ## I wouldn't include this header in a file that only adds a Kconfig option, but it doesn't hurt to keep it.