Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39857 )
Change subject: mb/google/volteer: Create Malefor variant
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39857/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/39857/1/src/mainboard/google/voltee...
PS1, Line 11: config BOARD_GOOGLE_MALEFOR
could you add this in alphabetical order?
https://review.coreboot.org/c/coreboot/+/39857/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39857/1/src/mainboard/google/voltee...
PS1, Line 1: /*
please replace with SPDX-License
in all of these files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbeebb13e537287686344740211143df35b7863a
Gerrit-Change-Number: 39857
Gerrit-PatchSet: 1
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-CC: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Comment-Date: Thu, 26 Mar 2020 20:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment