Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49210 )
Change subject: soc/intel/common: Pass in pci_devfn_t into lpss_set_power
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/49210/comment/b71c9258_d037632a
PS1, Line 469: gspi_soc_bus_to_devfn
For another patch: would it make sense to change this function to return a pci_devfn_t instead?
I think we need to look at cleaning up the entire pci_devfn_t/devfn, etc. in coreboot. But it will require a series of its own.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9e32794da65348fe2a0a2791db47ab83b64cb0f
Gerrit-Change-Number: 49210
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Jan 2021 17:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment