Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44092 )
Change subject: soc/intel/baytrail: Add MRC SMBus workaround ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/44092/1/src/soc/intel/baytrail/roms... File src/soc/intel/baytrail/romstage/raminit.c:
https://review.coreboot.org/c/coreboot/+/44092/1/src/soc/intel/baytrail/roms... PS1, Line 119: static u8 spd_buf[SPD_SIZE * NUM_CHANNELS] static u8 spd_buf[NUM_CHANNELS][SPD_SIZE];
https://review.coreboot.org/c/coreboot/+/44092/1/src/soc/intel/baytrail/roms... PS1, Line 169: for (i = 0; i < NUM_CHANNELS; ++i) nit: add braces around this big for-loop
https://review.coreboot.org/c/coreboot/+/44092/1/src/soc/intel/baytrail/roms... PS1, Line 172: &spd_buf[SPD_SIZE * i] spd_buf[i]
https://review.coreboot.org/c/coreboot/+/44092/1/src/soc/intel/baytrail/roms... PS1, Line 173: mp->mainboard.dram_data[i] = : &spd_buf[SPD_SIZE * i]; This always needs to be set to `spd_buf[0]` even for channel 1. Otherwise, it doesn't work.