Attention is currently required from: Nico Huber, Paul Menzel, Stefan Reinauer, Angel Pons.
Timofey Komarov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55839 )
Change subject: util/inteltool: Add PCH IDs for 200 series chipsets
......................................................................
Patch Set 7:
(1 comment)
File util/inteltool/pcr.c:
https://review.coreboot.org/c/coreboot/+/55839/comment/bce5c68a_d8358efc
PS2, Line 114: case PCI_DEVICE_ID_INTEL_H270:
: case PCI_DEVICE_ID_INTEL_Z270:
: case PCI_DEVICE_ID_INTEL_Q270:
: case PCI_DEVICE_ID_INTEL_Q250:
: case PCI_DEVICE_ID_INTEL_B250:
: case PCI_DEVICE_ID_INTEL_Z370:
: case PCI_DEVICE_ID_INTEL_H310C:
: case PCI_DEVICE_ID_INTEL_X299:
Moving this above leads to error messages about P2SB: […]
Well, right. My fault. Tested this, it works. Thank you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadad5e79aef9da3fac627adc135525a5001a72b6
Gerrit-Change-Number: 55839
Gerrit-PatchSet: 7
Gerrit-Owner: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 24 Oct 2021 15:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Timofey Komarov
happycorsair@yandex.ru
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment