[coreboot-gerrit] Change in coreboot[master]: google/herobrine: configure gpio to detect board ID.

[Sudheer Amrabadi (Code Review)]

Attention is currently required from: Shelley Chen, Ravi kumar, Ravi Kumar Bokka.
Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56642 )

Change subject: google/herobrine: configure gpio to detect board ID.
......................................................................

Patch Set 35:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/56642/comment/92f177b6_38824679 
PS35, Line 9: change binary board ID to tri-state mode.
> I don't think that you're doing this anymore in this CL...

Ack

Patchset:

PS35: 
Fixing as part of next patch train

File src/mainboard/google/herobrine/board.h:

https://review.coreboot.org/c/coreboot/+/56642/comment/3fc70567_5fc64d54 
PS20, Line 14: #define QCOM_SC7280_SKU3 0x3
             : #define QCOM_SC7280_SKU4 0x9
> HI Shelly, […]

Ack

File src/mainboard/google/herobrine/boardid.c:

https://review.coreboot.org/c/coreboot/+/56642/comment/b8456b3d_9dbb07aa 
PS18, Line 13: #if CONFIG(BOARD_GOOGLE_HEROBRINE)
             : 	const gpio_t pins[] = {[2] = GPIO(75), [1] = GPIO(74), [0] = GPIO(73)};
             : #elif CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)
             : 	const gpio_t pins[] = {[2] = GPIO(50), [1] = GPIO(49), [0] = GPIO(48)};
             : #end
> use C code?

Ack