Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31593 )
Change subject: mb/emulation/qemu: Fix fw_cfg file loading ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31593/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31593/1//COMMIT_MSG@7 PS1, Line 7: mb/emulation/qemu: Fix fw_cfg regression
You are not fixing a regression, you are fixing ACPI […]
Done
https://review.coreboot.org/#/c/31593/1//COMMIT_MSG@9 PS1, Line 9: The change I48cc943aaa999e4323e9d7e5dd666c5316533dcc
Please use a (shortened) commit hash.
Done
https://review.coreboot.org/#/c/31593/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/31593/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 457:
Same problem here, I guess.
Good catch