[coreboot-gerrit] [L] Change in coreboot[main]: autoport: Add support for Haswell-Lynx Point platform

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Iru Cai, Maxim, Name of user not set #1001638, Nicholas Chin, Paul Menzel.

Nico Huber has posted comments on this change by Iru Cai. ( https://review.coreboot.org/c/coreboot/+/30890?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: autoport: Add support for Haswell-Lynx Point platform
......................................................................

Patch Set 36: Code-Review+1

(2 comments)

File util/autoport/haswell.go:

https://review.coreboot.org/c/coreboot/+/30890/comment/79fdfe00_29a88e89?usp... :
PS36, Line 59: 7
What?

Oh, I see now. The lower bits used to mean something. I'm pretty sure
we want `& 4`.
Not sure why coreboot handles this anyway (VBIOS workaround?).

https://review.coreboot.org/c/coreboot/+/30890/comment/6d2df17b_4059d572?usp... :
PS36, Line 132: 		0x0d16, 0x0d22, 0x0d26, 0x0d36, /* Mobile 4+3, GT3e */
`gma.c` has 19 entries by now, I guess some are missing here?

Might add: I don't understand the mechanics here. The PCI devices all
have their fixed addresses. For the sake of platform detection, `1f.0`
should suffice.