23 Oct
2020
23 Oct
'20
8:56 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38424 )
Change subject: cbfs: Enable CBFS mcache on most chipsets ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38424/17/src/soc/amd/picasso/memlay... File src/soc/amd/picasso/memlayout_x86.ld:
https://review.coreboot.org/c/coreboot/+/38424/17/src/soc/amd/picasso/memlay... PS17, Line 88: CBFS_MCACHE(., CONFIG_CBFS_MCACHE_SIZE)
I've copied in the one ALIGN_COUNTER(64) from the PSP memlayout that prevents this issue now, I'll l […]
Build still failed. I'm not sure why. Seems to be the same message. I'll have to beat on this to sort it out, I think.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abd1c813aece6e78fb883f292ce6c9319545c44
Gerrit-Change-Number: 38424
Gerrit-PatchSet: 18
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 23 Oct 2020 18:56:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment