Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46433 )
Change subject: mrc_cache: Add config SAVE_MRC_CACHE for checking TPM hash ......................................................................
Patch Set 1:
(3 comments)
Kinda weird that this is in a separate patch rather than together with the code that actually makes the option do something?
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... PS1, Line 52: config SAVE_MRC_HASH nit: I think it's a little nicer for namespacing to start this with "MRC", e.g. MRC_SAVE_TPM_HASH or something.
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... PS1, Line 53: bool Currently with the way it's written, this feature needs to 'depends on VBOOT'. Technically we could disentangle it but that would be somewhat complicated (because we're using a lot of infrastructure code from secdata_tpm.c) so probably just easier to live with and enforce that dependency for the moment.
Also need to depend on 'TPM2'.
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... PS1, Line 56: nit: missing object