Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants
......................................................................
Patch Set 5:
Matt, have you verified the dmesg logging for the atlas and nocturne variants?
The vbt on these boards differs from the others (the config size is 39 vs 38 bytes). I have a similar vbt (Kabylake FSP 3.7.1. or newer) and get an error message indicating the configsize reported by the VBT is not correct.
This at least doesn't look nice. Before reporting this to Intel I wanted to make sure I am not the only one with this problem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37311
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052
Gerrit-Change-Number: 37311
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Mon, 16 Dec 2019 16:14:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment