Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )
Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45285/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45285/1//COMMIT_MSG@7
PS1, Line 7: trival: Fix typo of Kconfig setting
Please use a common prefix: soc/amd/picasso. […]
Changed.
https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil...
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil...
PS1, Line 152: PSPSCUREOS
good catch
This line will be removed at following patches in this stack.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c89975cc317cb93e79509e885010d14a79dd7e1
Gerrit-Change-Number: 45285
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Sep 2020 05:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment