[coreboot-gerrit] Change in coreboot[master]: amd/picasso: Load x86 microcode from CBFS modules

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )

Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................

Patch Set 17:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... 
File src/soc/amd/picasso/microcode_picasso.c:

https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... 
PS10, Line 48: 	/* patch authentication */
> // Do ucode patch Authentication […]

had another look at the PPR and this is indeed a check if the new microcode update got applied, which implies that the microcode loading mechanism in the core was able to authenticate the update, and doesn't do the actual microcode update authentication. but since the code is rather self-explaining here, i'd suggest to just drop this comment that i consider to be a bit misleading