Attention is currently required from: Felix Singer, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52776 )
Change subject: soc/intel/cannonlake: Rename `SOC_INTEL_COMETLAKE`
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Well, I don't care that much, but it would be consistent imo. […]
SOC_INTEL_COMETLAKE is still a valid option AFAICS. We just wouldn't know
what FSP to take. But we can't guarantee that any of the existing FSPs
actually work, so it's all vague anyway. If you want to enforce it, you
could add a dependency to SOC_INTEL_COMETLAKE. e.g.
config SOC_INTEL_COMETLAKE
def_bool y
depends on SOC_INTEL_COMETLAKE_1 || ...
and drop the selects.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52776
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I993f96f032c3b76a464474c83fee4442968be152
Gerrit-Change-Number: 52776
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 30 Apr 2021 20:23:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment