Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40278 )
Change subject: mb/purism/librem_whl: Add new board Librem Mini (WHL-U) ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
This looks like a nice little device, do you happen to know if it can be powered from the type-c port?
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... File src/mainboard/purism/librem_whl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... PS8, Line 96: Type-A front left upper You might consider describing these ports in the ACPI XHCI config as well, having the kernel report which ports are external can be useful in a media center or a kiosk application that wants to lock down external ports. Currently this has to be listed separately in devicetree but I've been thinking of ways to unify it. (example https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... )
Also related is the option to enable wake-on-attach/detach for the external ports, another feature that I have found useful in a media center setup but obviously can be more of a product behavior decision: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
Neither of these actually matter for base functionality and aren't exactly critical so feel free to ignore.
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... PS8, Line 136: AcousticNoiseMitigation I think enabling this without any of the related settings (slew rates) isn't going to do anything.