Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40592 )
Change subject: drivers/intel/gma: put controller in separate header ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40592/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40592/5//COMMIT_MSG@10 PS5, Line 10: along all of i915_reg.h
Actually something we could fix as well. why have all the indirect […]
what do you propose here? or something for a follow on patch?
https://review.coreboot.org/c/coreboot/+/40592/5//COMMIT_MSG@11 PS5, Line 11: Apollolake
woups, was lost from PS3
Done
https://review.coreboot.org/c/coreboot/+/40592/5/src/drivers/intel/gma/gma.h File src/drivers/intel/gma/gma.h:
https://review.coreboot.org/c/coreboot/+/40592/5/src/drivers/intel/gma/gma.h... PS5, Line 4: I915_
nit, doesn't reflect path/filename […]
Done
https://review.coreboot.org/c/coreboot/+/40592/5/src/drivers/intel/gma/gma.h... PS5, Line 20: void
This was also undone
Done