Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34296 )
Change subject: soc/rockchip/rk3288: Add fall through comment
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34296/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34296/3//COMMIT_MSG@7
PS3, Line 7: Add missing break statement
Is it really missing, or is it intentionally not there?
Done
https://review.coreboot.org/c/coreboot/+/34296/3/src/soc/rockchip/rk3288/sdr...
File src/soc/rockchip/rk3288/sdram.c:
https://review.coreboot.org/c/coreboot/+/34296/3/src/soc/rockchip/rk3288/sdr...
PS3, Line 911: break;
To not change the code flow, please add a "fallthrough comment": a comment stating this fallthrough […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34296
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d0cfea07211c54d6a906f5a7481c2c760f8ef0d
Gerrit-Change-Number: 34296
Gerrit-PatchSet: 4
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Jul 2019 17:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment