mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30746 )
Change subject: drivers/spi/winbond.c: Add the rest of >=1MB Winbond W25 chips
......................................................................
Patch Set 1: Code-Review+1
I think this change could be accepted because if .protection_granularity_shift=16 worked for W25Q256_V then it should work for a similar W25Q256J(V). Later I could send a separate patch which will change .protection_granularity_shift for W25Q256* chips from 16 to 19 , following the logic of W25Q32*=16 / W25Q64*=17 / W25Q128*=18
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30746
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d15d5acf0e2044e5128ce809c282fbcb35f24f0
Gerrit-Change-Number: 30746
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Comment-Date: Wed, 16 Jan 2019 21:21:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment