Attention is currently required from: Shelley Chen, Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 15:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/7b5d2ce7_a4bec13f PS15, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/3d24863a_c34ceda8 PS15, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/8d85eedf_eb3f1572 PS15, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/167c553b_51f2ac9c PS15, Line 204: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/d8f90e5f_c0934278 PS15, Line 205: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/ece5adc6_18cb549a PS15, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/5a6d83d8_434dd7b8 PS15, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/bea07e83_f1a0b13f PS15, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/18117336_2ee08472 PS15, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/e3bdfb42_fc1f2ad1 PS15, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120402): https://review.coreboot.org/c/coreboot/+/52371/comment/e92dca31_f2eb957a PS15, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)