Attention is currently required from: Martin Roth, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56593 )
Change subject: util/lint/lint-stable: Add forbidden Kconfig check ......................................................................
Patch Set 2:
(1 comment)
File util/lint/lint-stable-028-forbidden-config-c:
https://review.coreboot.org/c/coreboot/+/56593/comment/4c665238_346db01a PS2, Line 23: -I %
We should probably use both methods, similar to what's done in the whitespace linter. […]
I was refering to the `-I` specifically. Generally, there is nothing wrong with using xargs. It's a good idea to do so. xargs is only slow if it creates too many subprocesses, but it tries to minimize that by default.
The problem that CB:28429 tries to avoid is when we use the stdout of one program directly as command line for another. This can always overflow, I'd even expect it to on Linux at some point. We should use xargs instead whenever possible.
When it comes to grepping in the repository, we often don't have to use multiple programs, though (see above example).