Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44092 )
Change subject: soc/intel/baytrail: Add MRC SMBus workaround
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44092/4/src/soc/intel/baytrail/roms...
File src/soc/intel/baytrail/romstage/raminit.c:
https://review.coreboot.org/c/coreboot/+/44092/4/src/soc/intel/baytrail/roms...
PS4, Line 170: if (mp->mainboard.spd_addrs[i]) {
: i2c_eeprom_read(mp->mainboard.spd_addrs[i],
: 0, SPD_SIZE, spd_buf[i]);
: /* NOTE: the MRC expects both SPD pointers
: to match */
: mp->mainboard.dram_data[i] = spd_buf;
: }
Actually, the data buffers can be different, but the data for channel 0 needs to be at index 0, and […]
Reading it again, I'd reword the comment:
Note: MRC looks for Channel 1 SPD at array index 1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44092
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f560d950cb4e4d118f3ee17e6e19e14cd0cc193
Gerrit-Change-Number: 44092
Gerrit-PatchSet: 4
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 02 Aug 2020 12:16:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri
kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment