28 May
2024
28 May
'24
4:57 p.m.
Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Paul Menzel.
Felix Singer has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82671?usp=email )
Change subject: ec/dasharo/ec: add support for Dasharo EC ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82671/comment/b42f4539_09e7aafd?usp... : PS3, Line 7: ec/dasharo/ec: add support for Dasharo EC Since this is just a copy and the actual Dasharo features / flavor is added later, please rephrase.
How about: ``` ec/dasharo/ec: Add initial copy of ec/system76/ec ```
Otherwise it looks good to me.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82671?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic7c3d9413488026548514963eb78accc28e41e06
Gerrit-Change-Number: 82671
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 28 May 2024 19:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes