Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )
Change subject: util/lint: check for Change-Id line presence and duplicates
......................................................................
Patch Set 3:
(1 comment)
Just to be sure, for developers having linting enabled, this will be run after the commit message has been written and updated by the “Change-Id adding hook”?
I was also wondering when it is supposed to be run?
https://review.coreboot.org/c/coreboot/+/33884/3/util/lint/lint-extended-024...
File util/lint/lint-extended-024-change-id:
https://review.coreboot.org/c/coreboot/+/33884/3/util/lint/lint-extended-024...
PS3, Line 2: CHANGE_ID_LINECOUNT=$(git log -n 1 | grep -c '[[:space:]]+Change-Id: ')
Original-Change-Id is not matched, right?
Right.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4
Gerrit-Change-Number: 33884
Gerrit-PatchSet: 3
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Dec 2019 14:50:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment