Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32337 )
Change subject: vendorcode/google/chromeos: Add CHROMEOS_SOC_DEBUG_CONSENT Kconfig
......................................................................
Patch Set 2:
Patch Set 1:
Why is it Chromium OS specific?
it's not Chromium OS specific.
Other OS can directly control DEBUG_CONSENT_CANNONLAKE.
it's main switch for chrome OS developers to control soc debug capability like DEBUG_CONSENT_CANNONLAKE config.
Going forward, there might be some other new settings for other chipset to enable debug capability and this main switch can still be used
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I313d80d6c63fd37164c63f78e9e69d3cb4a5566b
Gerrit-Change-Number: 32337
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Apr 2019 15:18:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment