[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Support reset vector in romstage

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33759 )

Change subject: soc/amd/picasso: Support reset vector in romstage
......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33759/20/src/soc/amd/picasso/Makefi... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/33759/20/src/soc/amd/picasso/Makefi... 
PS20, Line 211: ifeq ($(CONFIG_RESET_VECTOR_IN_RAM_ROMSTAGE),y)
> AFAICS if you incorporate ELF parsing into amdfwtool and remove the separate util/cbfstool/amdcompre […]

Yes, you're right.  However the reason I wanted to keep it out of amdfwtool was looking forward for when the biosbin might need to be somewhere outside of the traditional amdfw.rom.  If we rely on amdfwtool (assuming a single pass), then it won't know where to set the source field. Maybe it could be moved there, providing the option of doing a simple single pass or one to build the boisbin and another that could pass an image and source address on the command line.