build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29955 )
Change subject: qcs405: Add GPIO API
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29955/1/src/soc/qualcomm/qcs405/include/soc/...
File src/soc/qualcomm/qcs405/include/soc/gpio.h:
https://review.coreboot.org/#/c/29955/1/src/soc/qualcomm/qcs405/include/soc/...
PS1, Line 90: #define PIN(index, tlmm, func1, func2, func3, func4, func5, func6, func7) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ce9007c545b44371c4704a0456774d0eff12a8
Gerrit-Change-Number: 29955
Gerrit-PatchSet: 1
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Nov 2018 10:15:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment