build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37130 )
Change subject: arch/riscv: Add error detection for supports_extension
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37130/2/src/arch/riscv/include/arch...
File src/arch/riscv/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/37130/2/src/arch/riscv/include/arch...
PS2, Line 64: "The parameter of supports_extension must be [A-Z]");\
Prefer using '"%s...", __func__' to using 'supports_extension', this function's name, in a string
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5df3d82b9a9b4968beea6040b86628b58fd8a45d
Gerrit-Change-Number: 37130
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Comment-Date: Mon, 25 Nov 2019 08:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment