Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48749 )
Change subject: soc/intel/cnl: add panel and backlight configuration code
......................................................................
Patch Set 31: Code-Review+2
I find the additional brackets quite irritating but they seem
correct so let's get it in.
Generally I believe brackets are not a good way to make things
more human readable. If you want to make the execution order
clearly visible, you can use intermediate statements. Each on
one line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48749
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If619b28478b4b0d18f28f318c16336e0de76e129
Gerrit-Change-Number: 48749
Gerrit-PatchSet: 31
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Jan 2021 21:00:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment