Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33620 )
Change subject: soc/amd: Update ACPI code ......................................................................
Patch Set 2:
Patch Set 2:
I think you should separate your OS stuff into a separate stack. Keep the additional cores change for the merlinfalcon work.
This is for merlinfalcon, as the same ASL is used both for stoneyridge and merlinfalcon.
I understand that. My suggestion is that maybe you shouldn't be trying to fix OS incompatibilities on Stoney Ridge until you have more information. Simply make a stack that adds Merlin Falcon support to the stoneyridge directory. This will be a lot easier to review and approve than a stack containing unrelated ACPI changes. Or you could move the ACPI changes to the top of the stack, maybe, because this shouldn't affect making stoneyridge backward compatible.
Agree on that. I had a reason when I started, but OSFL was already separated and maybe abandoned, so it really makes no sense to separate it anymore. Will abandon this patch and add cpu.asl to the actual merlinfalson soc patch.