Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@9 PS1, Line 9: Current code surreptitiously selected Prairie Falcon if Merlin Falcon is : selected and no Merlin Falcon binaries are available.
I don't understand what you mean about Prairie Falcon being selected - you're adding it to this comm […]
If you build padmelon using Merlin Falcon, but without Merlin Falcon binaries, the resulting image will boot a padmelon using Prairie Falcon. I wanted to do it more explicit, as only I knew the fact...
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@16 PS1, Line 16: only Stoneyridge is combo capable
Can you elaborate why are you confident that Prairie Falcon is not combo-capable? That product is F […]
Combo capable was explicitly developed for Google. Google never used Prairie Falcon, thus I assume that its base code (permanently programmed to it, which will then load external code from SPI) never got such capability... I might be wrong, it may be possible to add the capability to one such external code.
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@18 PS1, Line 18: Merlin Falcon uses the same internal CPU as Carrizo, thus it has dual memory : channel while Prairie Falcon and Stoney ridge have only one channel.
This really has nothing to do with the PSP blobs, and is more of a feature definition for the APU ty […]
I just wanted to differentiate between Merlin Falcon and Prairie Falcon. It's the only difference I'm aware between these 2 SOCs. If you want, I can always remove, but I believe it's a valid comparison.
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@20 PS1, Line 20: one particular version of Carrizo binaries
Not sure what you mean by version(s) of Carrizo binaries. […]
Yes...Maybe I should have said Bristol Ridge instead of Carrizo. Not sure why, but some BR binaries I tried did not work with Merlin Falcon (though IIRC the latest one did). Will replace with Bristol Ridge.