Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31095 )
Change subject: src/soc/intel/cnl/chip.h: Fix preprocessor condition
......................................................................
Patch Set 5:
Patch Set 4:
we will take this clean up activity to remove hard coding for sagv config in devicetree.cb and make use of macro as applicable. That would helped us to catch this issue on WHLRVP in absence of hatch board in lab.
I will push patch for hard coding clean up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a6959bb615fb5668cbfe54339747d135bd5a005
Gerrit-Change-Number: 31095
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Jan 2019 06:39:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment