Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36874 )
Change subject: soc/intel/baytrail: Start VBOOT in bootblock
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36874/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36874/4//COMMIT_MSG@9
PS4, Line 9: The earlier the more that can be updated via RW fmap regions.
Except for the mrc.bin, which isn't relocatable. I think that's why this is configured that way. So, is it useful to have romstage twice if both copies call into the same mrc?
Not everything is done by the mrc.bin.
The mrc is actually an elf instead of a plain binary so it might be possible to relocate it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcaf6ad8e27c09fee99cf6a8b12f9fadcb0cef2c
Gerrit-Change-Number: 36874
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jun 2020 20:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment