[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Introduce SKU_ID helpers

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )

Change subject: ec/google/chromeec: Introduce SKU_ID helpers
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39018/3/src/ec/google/chromeec/ec_b... 
File src/ec/google/chromeec/ec_boardid.c:

https://review.coreboot.org/c/coreboot/+/39018/3/src/ec/google/chromeec/ec_b... 
PS3, Line 48: google_chromeec_smbios_system_sku
> The trouble is the weak symbol smbios_system_sku is general and not necessarily a Google thing.

I think that should be fine. ec_skuid.c gets included only when a Google board using Chrome EC actually selects it. So, providing a stronger definition of smbios_system_sku() here would impact only those boards.