build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28353 )
Change subject: google/grunt: Reset BayHub EMMC freq to SD base CLK 50MHz ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants... PS1, Line 54: write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_READ | BH720_PCR_EMMC_SETTING); line over 80 characters
https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants... PS1, Line 56: write32((void *)(sdbar + BH720_MEM_RW_DATA), bh720_pcr_data | BH720_PCR_EMMC_SETTING_1_8V); line over 80 characters
https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants... PS1, Line 57: write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_WRITE | BH720_PCR_EMMC_SETTING); line over 80 characters
https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants... PS1, Line 60: write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_READ | BH720_PCR_CSR); line over 80 characters
https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants... PS1, Line 62: write32((void *)(sdbar + BH720_MEM_RW_DATA), bh720_pcr_data & ~BH720_PCR_CSR_EMMC_MODE_SEL); line over 80 characters
https://review.coreboot.org/#/c/28353/1/src/mainboard/google/kahlee/variants... PS1, Line 63: write32((void *)(sdbar + BH720_MEM_RW_ADR), BH720_MEM_RW_WRITE | BH720_PCR_CSR); line over 80 characters