Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )
Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
I agree with changing the defaults to something that works out-of-the-box. See my comment, though.
https://review.coreboot.org/c/coreboot/+/34166/1/src/soc/intel/cannonlake/Kc...
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/34166/1/src/soc/intel/cannonlake/Kc...
PS1, Line 273: Cache-as-ram implementation
Where do these prompts get their default value from, now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a880f3093887628ce6bc9c39758e43688345713
Gerrit-Change-Number: 34166
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:20:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment