Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41460 )
Change subject: cpu/intel/slot_1: Select 16KiB bootblock if console is enabled ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... File src/cpu/intel/slot_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/41460/2/src/cpu/intel/slot_1/Kconfi... PS2, Line 37: default 0x4000 if BOOTBLOCK_CONSOLE
Can't we always default to 0x4000? Or is flash space a scarce resource?
These boards only have a 256KiB flash and it is not known if they can handle a 512KiB chip. So yes, flash space IS a scarce resource. Heads up: Our LTO effort allows this bootblock to go below 4KiB and I have a patch ready to take advantage of that.