Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(3 comments)
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/Kconfig@9 PS2, Line 9: DRIVERS_GENERIC_GPIO_KEYS
Can you please add this in alphabetical order?
Done
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject""
Are you planning to add wake support later on?
I am not sure the behavior definition. Can you give me some suggestion?
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 34: UP_20K
Why is the pull-up required here? There is already an external pull-up on this line.
Done