Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant ......................................................................
Patch Set 6: Code-Review-1
tl;dr don't expect this to work.
looks good to me, but should be tested again before i give a +2
I have build current master (edbf5d91) with patch set 6 applied for both a normal x230 and x230_fhd. I have tested the following setup: coreboot -> seabios -> grub on both devices.
The normal x230 works as expected.
On the device with FHD-mod booting works as well, but graphical output of coreboot, seabios and grub is only visible if an additional external monitor is attached via VGA or DP. The internal FHD panel becomes active as soon as the linux kernel takes over. Right now I am unsure if this is due to misconfiguration on my part or if coreboot/libgfxinit needs to be told to use eDP1 for output on modded devices.
That is exactly the problem. libgfxinit needs to be taught to treat the DP as eDP (i.e. with a panel attached). That's what I said in my very first comment on this change ;) to avoid all the confusion. Obviously that wasn't visible enough, hence the score now.
It only works by coincidence with the setup this was tested with originally. So please either write down what exact setup this was, or implement proper power sequencing first.