Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41885 )
Change subject: dptf: Add support for generation of Active Policies
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41885/10/src/acpi/acpigen_dptf.c
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/41885/10/src/acpi/acpigen_dptf.c@17
PS10, Line 17: 1/10 degree Kelvin
I am confused by the calculation/comment here: […]
That would be 10s of degrees Kelvin (decadegrees K). ACPI uses decidegrees Kelvin. Example: 50 degrees C would be 3232 (323.2 degrees K, or 3232 decidegrees K). Your calculation would make that 32.3 (decadegrees K).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea0ccbd96f88d0f3a8f2c77a7d0f3a284e5ee463
Gerrit-Change-Number: 41885
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jun 2020 23:11:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment