Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34976 )
Change subject: cpu/intel/car: Make stack guards more useful on C_ENV_BOOTBLOCK
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34976/4/src/cpu/intel/car/romstage....
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34976/4/src/cpu/intel/car/romstage....
PS4, Line 35: size = MIN(size, stack_size);
looking at the linker script _car_stack_size is the same as CONFIG_DCACHE_BSP_STACK_SIZE. Why do you need this check?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ce1dda4d1f254e6c36de4d3fea26e12c34195ff
Gerrit-Change-Number: 34976
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 18 Aug 2019 07:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment