Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )
Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/smihandler.c:
https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede...
PS2, Line 44: MAINBOARD_EC_S0IX_WAKE_EVENTS);
Does this fit into 96 characters?
I have put the entire statement in a line < 96 characters. Hope checkpatch is updated to handle 96 characters limit. /util/lint/checkpatch.pl complains about greater than 80 characters.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dffa5c021787dca75786ead42164bd29ba56828
Gerrit-Change-Number: 38724
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Feb 2020 18:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment