Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37072 )
Change subject: Add network update functionality ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/em100/+/37072/14/curl.c File curl.c:
https://review.coreboot.org/c/em100/+/37072/14/curl.c@51 PS14, Line 51: =
maybe add space around the equals symbol here and on the next line? […]
Done
https://review.coreboot.org/c/em100/+/37072/14/curl.c@62 PS14, Line 62: written
Couldn't this be returned directly?
Done
https://review.coreboot.org/c/em100/+/37072/14/curl.c@83 PS14, Line 83: return -1;
Potential leak? […]
Done
https://review.coreboot.org/c/em100/+/37072/14/curl.c@145 PS14, Line 145: return 1;
Potential leak? […]
Done
https://review.coreboot.org/c/em100/+/37072/14/curl.c@153 PS14, Line 153: !=2
Missing space here and on the next line
Done