Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37767 )
Change subject: util/inteltool: fix Ie00fef5a5ba2779e0ff45640cff5cc9f1d096dc1 on FreeBSD
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/Makefile
File util/inteltool/Makefile:
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/Makefile@26
PS1, Line 26: CFLAGS += -Wno-unused-function
Please elaborate, why this is needed.
This is a cosmetic solution to hide useless output like ./inteltool.h:373:14: warning: unused function 'freebsd_rdmsr' [-Wunused-function]
With or without this line, a binary will be built.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aba72f39b528fd70451a4656fd6c835ff766e49
Gerrit-Change-Number: 37767
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Dec 2019 23:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment