Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31110 )
Change subject: soc/intel/skylake: select FSP_M_XIP if MAINBOARD_USES_FSP2_0
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31110/4/src/soc/intel/skylake/Kconfig
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/#/c/31110/4/src/soc/intel/skylake/Kconfig@31
PS4, Line 31: FSP_M_XIP
This is true regardless of the FSP version. Sorry if I missed it but did we drop fsp 1.1. […]
We didn't drop FSP1.1. But it doesn't know the `FSP_M_XIP` Kconfig symbol, hence the guard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31110
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d3986eda18297b12490cefb236f5de5faca6550
Gerrit-Change-Number: 31110
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Jan 2019 16:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment