Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Tim Chu, Ziang Wang.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81440?usp=email )
Change subject: soc/intel/xeon_sp: Add device to proximity domain map utils
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81440/comment/cfc5c72c_c4379cfa :
PS6, Line 18: SNC
What does SNC mean? I would at least expand the acronym
Sub-NUMA cluster, commit message updated.
File src/soc/intel/xeon_sp/numa.c:
https://review.coreboot.org/c/coreboot/+/81440/comment/84a46e5d_e62bd17f :
PS6, Line 122: uint32_t
Use `enum proximity_domain_type`. […]
Nice catch! Updated.
https://review.coreboot.org/c/coreboot/+/81440/comment/86f43410_b541a24b :
PS6, Line 130: return PD_TYPE_MAX;
Would it be a good idea to log a warning/error when the pd couldn't be found?
Sure, updated.
https://review.coreboot.org/c/coreboot/+/81440/comment/a2e2376f_76c0d550 :
PS6, Line 147: return PD_TYPE_MAX;
Same here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81440?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd14a98823491ccfc38473e44a26dddfbbcaa7c0
Gerrit-Change-Number: 81440
Gerrit-PatchSet: 6
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 30 Apr 2024 11:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment