Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42470 )
Change subject: drivers/intel/mipi_camera: Add support to handle CIO2 device
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42470/6/src/drivers/intel/mipi_came...
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42470/6/src/drivers/intel/mipi_came...
PS6, Line 13:
: #define CIO2_PCI_DEV 0x14
: #define CIO2_PCI_FN 0x3
: #define SENSOR_NAME_UUID "822ace8f-2814-4174-a56b-5f029fe079ee"
: #define SENSOR_TYPE_UUID "26257549-9271-4ca4-bb43-c4899d5a4881"
: #define DEFAULT_REMOTE_NAME "\_SB.PCI0.CIO2"
: #define DEFAULT_ENDPOINT 0
nit: line these all up with tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I521740524bc1c4da3d8593f011a033542e4a872c
Gerrit-Change-Number: 42470
Gerrit-PatchSet: 6
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 21:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment