[coreboot-gerrit] Change in coreboot[master]: arch/x86: Use a common cbmem_top implementation

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36144 )

Change subject: arch/x86: Use a common cbmem_top implementation
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36144/4/src/arch/x86/cbmem.c 
File src/arch/x86/cbmem.c:

https://review.coreboot.org/c/coreboot/+/36144/4/src/arch/x86/cbmem.c@19 
PS4, Line 19: void *cbmem_top_romstage(void)
> This function isn't declared.

It is done in the previous patch.

https://review.coreboot.org/c/coreboot/+/36144/4/src/arch/x86/cbmem.c@24 
PS4, Line 24: 	if (ENV_RAMSTAGE && cbmem_top_backup != NULL)
> Clean this up as well? If this function is only used in romstage then we should remove all of this? Or make it work with the original intent.

This idea was to clean things up in a separate patch to remove the custom backing up mechanisms. Hence the renaming of all cbmem_top implementation to make the linker happy.