Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37490 )
Change subject: soc/amd/picasso: Add bootblock support ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37490/7/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/37490/7/src/soc/amd/picasso/Kconfig... PS7, Line 225: 0x807fff0
the last 16 bits are architectural; have to look into the first 16 bits, but my guess would be that […]
I'm wondering if this needs to be kept in sync with hardware or software (e.g. PSP firmware).
https://review.coreboot.org/c/coreboot/+/37490/7/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37490/7/src/soc/amd/picasso/Makefil... PS7, Line 44: bootblock-y += smi_util.c
some functions in there are used by the gpio setup function. […]
There is also SCI configuration in there which makes a bit more sense, however I couldn't find the exact path that leads there. Also wondering what exactly is needed in the bootblock, on some Intel platforms we do GPIO configuration much later, in the ramstage.